[drupal-devel] [bug] "TYPES" is not a legal field name table "BLOCKS"

[andremolnar]

 Project:      Drupal
 Version:      cvs
 Component:    block.module
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  Philippe
 Updated by:   andremolnar
 Status:       patch
 Attachment:   http://drupal.org/files/issues/blocks_db_change_5.patch (1.79 KB)

And the db files and upgrade path.


andremolnar



Previous comments:
------------------------------------------------------------------------

February 5, 2005 - 13:31 : Philippe

There was a "TYPES" field added to the BLOCKS table. MySQL does not like
this; "types" is considered a reserved word. (MySQL-server-4.1.0-0) The
field name needs to be changed to something else.


------------------------------------------------------------------------

February 5, 2005 - 13:37 : Philippe

Attachment: http://drupal.org/files/issues/types.diff (3.51 KB)

here's a patch


------------------------------------------------------------------------

February 9, 2005 - 21:35 : andremolnar

Changing Status to patch.
I guess we didn't catch this - the field wasn't orginally called types.
 Good eye.
andre


------------------------------------------------------------------------

February 9, 2005 - 21:39 : Dries

I suggest we name this field 'nodes'.  Also, we'll need an upgrade path
for those who are running CVS HEAD.


------------------------------------------------------------------------

February 9, 2005 - 21:54 : JonBob

I'm a bit confused by this. The word "types" doesn't show up here:
http://dev.mysql.com/doc/mysql/en/reserved-words.html


------------------------------------------------------------------------

February 9, 2005 - 22:12 : andremolnar

I remembered seeing it here:  http://drupal.org/node/2497  If this is
incorrect, then the documentation needs to be changed.
But all in all, nodes isn't a bad idea - I can submit a patch along
with the upgrade path if 'types' is indeed a reserved word in either
mySQL or pgSQL.
andre


------------------------------------------------------------------------

February 11, 2005 - 01:22 : ax

"TYPES" /is/ a reserved word in mysql 4.1.0 [1] and 4.1.1 [2]. it
doesn't show up at
http://dev.mysql.com/doc/mysql/en/reserved-words.html because it isn't
reserved anymore since some point release later. it isn't even
documented in the mysql changelog that it has ever been a reserved word
...
once again the suggestion to get rid of sql reserved words issues once
and for all [3]
[1] http://drupal.org/node/1612
[2]
http://info.ccone.at/INFO/MySQL-Doc/manual_Reference.html#Reserved_words
[3] http://drupal.org/node/4907#sql-reserved-word-fix


------------------------------------------------------------------------

February 11, 2005 - 14:27 : andremolnar

I'll submit a patch later today to use the word 'nodes' in block - along
with the database upgrade path.
andre


------------------------------------------------------------------------

February 11, 2005 - 14:40 : andremolnar

Attachment: http://drupal.org/files/issues/block_module_7.patch (1.69 KB)

Here is the patch to block.module


-- 
View: http://drupal.org/node/16817
Edit: http://drupal.org/project/comments/add/16817