[drupal-devel] [bug] Putting a .theme file into themes/ makes all themes not working

[chx]

 Project:      Drupal
 Version:      cvs
 Component:    theme system
 Category:     bug reports
 Priority:     critical
 Assigned to:  chx
 Reported by:  chx
 Updated by:   chx
 Status:       patch
 Attachment:   http://drupal.org/files/issues/themefix.patch (693 bytes)

Anonymous is right. I have made a better patch. Please commit, this is
very important IMHO.


chx



Previous comments:
------------------------------------------------------------------------

February 7, 2005 - 08:13 : chx

Try putting a .theme file into themes/ without any subdir. Enable it
(maybe just saving theme settings is enough), Nothing will work after
this. To restore your site: remove the offending theme, issue an SQL:
DELETE FROM {system} WHERE type='theme' and save theme settings again.


------------------------------------------------------------------------

February 7, 2005 - 08:14 : chx

effects HEAD, too.


------------------------------------------------------------------------

February 7, 2005 - 13:33 : chx

Attachment: http://drupal.org/files/issues/themesfix.patch (542 bytes)

Here is a patch which fixes the problem. However, I do not have the
feeling that this is "the" solution. Feel free to come up with
something better.


------------------------------------------------------------------------

February 7, 2005 - 13:35 : chx

Oops forgot to set to CVS, 'cos the fix is against HEAD. Not that 4.5.2
does not need a patch...


------------------------------------------------------------------------

February 7, 2005 - 22:15 : Anonymous

While this patch would allow a theme to be placed directly in the
"themes" directory, it disables the ability for that theme to use a
"style.css" file, which is inconsistent. I would prefer a patch that
enforces the criteria that themes MUST be placed in a SUBDIRECTORY of
"themes" -- themes placed directly in the "themes" folder should be
ignored... maybe we could send the admin a drupal_set_message that
would tell them about the problem when visiting admin/themes too.


-- 
View: http://drupal.org/node/16914
Edit: http://drupal.org/project/comments/add/16914