[drupal-devel] [task] Add a preview class to node previews

rkendall drupal-devel at drupal.org
Thu Feb 24 11:20:35 UTC 2005

 Project:      Drupal
 Version:      cvs
 Component:    node system
 Category:     tasks
 Priority:     normal
 Assigned to:  drumm
 Reported by:  drumm
 Updated by:   rkendall
 Status:       patch

I think this is a good idea.  The more themeable the better, as long as
there is some sensible overall use of class names etc.  ("preview" does
make sense to me)
Just one comment/question, does Drupal have some kind of overall plan
for the use of HTML class/id names etc.?  ...and how div's are nested
in the output HTML as well?
I like the idea of as much being themeable by CSS as possible, but
maybe we also need to be careful to keep the CSS themeing as simple and
consistent as possible - as well.
...just trying to get the bigger picture in mind.


Previous comments:

February 24, 2005 - 09:06 : drumm

Attachment: http://drupal.org/files/issues/node.module_1.diff (2.34 KB)

Chris (factoryjoe) wanted to be able to theme node previews differently
from the other node views. I decided to add a div around the whole
preview area which includes one or two node views, trimmed and not
trimmed. And I went ahead and put the whole thing in a themeable
function since the is a lot of HTML there.

View: http://drupal.org/node/17870
Edit: http://drupal.org/project/comments/add/17870

More information about the drupal-devel mailing list