[drupal-devel] [feature] br tag before buttons in node.module

[Steven]

 Project:      Drupal
 Version:      cvs
 Component:    node.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  grantbow at civicspacelabs.org
 Updated by:   Steven
 Status:       patch

Sounds like your theme is missing a clear attribute somewhere, but your
description isn't exactly clear.

Steven



Previous comments:
------------------------------------------------------------------------

January 16, 2005 - 09:53 : grantbow at civicspacelabs.org

Attachment: http://drupal.org/files/issues/node.module (60.79 KB)

On my site the preview and submit buttons appear to the right side of
the trackback block.  Users who expect the buttons to be at the bottom
of the page have a (extremely small) hurdle to find the buttons. 
Sometimes the buttons are rendered into the next column due to the
width of the trackback block.  While I am not aware if this happens on
all sites, I wanted to offer a simple patch that works well on my own
site.  If this fix not in the proper place I would appreciate
constructive feedback on where it does belong.  Thanks.

Index: node.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/node.module,v
retrieving revision 1.439
diff -u -F^fun -r1.439 node.module
--- node.module 11 Jan 2005 09:41:49 -0000      1.439
+++ node.module 16 Jan 2005 08:43:19 -0000
@@ -1220,6 +1220,7 @@ function node_form($edit) {
   $output .= form_hidden('type', $edit->type);
 
   // Add the buttons.
+  $output .= '';
   $output .= form_submit(t('Preview'));
 
   if (!form_get_errors()) {


------------------------------------------------------------------------

January 16, 2005 - 09:55 : grantbow at civicspacelabs.org

Attachment: http://drupal.org/files/issues/node.module_2.patch (510 bytes)

It would help if I attached the correct file.

------------------------------------------------------------------------

January 16, 2005 - 10:03 : chx

Attachment: http://drupal.org/files/issues/node.module_3.patch (504 bytes)

/ instead of \

Otherwise +1.

------------------------------------------------------------------------

January 16, 2005 - 10:21 : tangent

This is not at all a semantic solution. This should be handled by the
theme, preferably with CSS.

-- 
View: http://drupal.org/node/15679
Edit: http://drupal.org/project/comments/add/15679