[drupal-devel] [bug] "Add new comment" no longer shows up in $links?

[Junyor]

 Project:      Drupal
-Version:      4.5.1
+Version:      4.5.2
 Component:    poll.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  Morbus Iff
 Updated by:   Junyor
 Status:       patch

Note: The attached patch is a good solution for 4.5.2.  For HEAD, all
hook_link functions need to have their parameter list updated to make
sure they're using $teaser and not $main.  Same goes for node_link. 
Additionally, we should think about adding a theme function to handle
hook_block links (if one doesn't already exist).

Junyor



Previous comments:
------------------------------------------------------------------------

December 30, 2004 - 15:41 : Morbus Iff

I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll
block no longer displays the "add new comment" or "# comments" link.
This is (was) important to me, as I usually ask for comments whenever
someone chooses the negative option. Any idea where and why this went?
You can still get to the comment form in a roundabout way ("other
polls", choose your poll, whammo), but that's far too many clicks and
intellect points.

------------------------------------------------------------------------

January 18, 2005 - 16:50 : rooey

I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2
:(

There is *some* info on comment issues here:
http://drupal.org/node/11366

I didn't find any of them solved this particular issue tho.

------------------------------------------------------------------------

January 18, 2005 - 18:28 : Junyor

So, not even the "add new comment" link is showing up?  I just loaded
the poll module and that shows fine.  However, the current comment
count doesn't show correctly in the block.

This is what I've seen so far:
1) poll_block calls poll_view
2) poll_view calls poll_view_voting, which outputs the poll choices
3) for blocks, poll_view calls link_node, which calls hook_link('node')
in each module.  For all other poll displays, the theme does the call to
link_node (via node_view)

I'm guessing poll_view is where the problem is.  I'll keep looking at
it.

------------------------------------------------------------------------

January 18, 2005 - 18:41 : Junyor

Changing the call to link_node on line 438 in poll.module (in poll_view)
to:



------------------------------------------------------------------------

January 18, 2005 - 18:51 : Junyor

Trying again with correct PHP tags. :)

Changing the call to link_node on line 438 in poll.module (in
poll_view) to:



seems to solve the problem.  I'm trying to look now at the history of
link_node to see why that fixed it.  That's the same parameters that
the call in theme_node uses.

------------------------------------------------------------------------

January 18, 2005 - 18:58 : Junyor

Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes)

The change to theme_node was done as part of
http://drupal.org/node/9287.  Other than theme_node, poll_view is the
only function that calls link_node directly.

Attached is a patch to fix the function call in poll_view to send the
correct parameters.

------------------------------------------------------------------------

January 18, 2005 - 19:21 : Morbus Iff

Confirmed Junyor's patch. Excellent (note: take my confirmation with a
grain of salt. One of my previous patches caused a grievous bug for
4.5.2 tracker.module, and I should not be trusted anymore <g>).

------------------------------------------------------------------------

January 18, 2005 - 19:22 : Morbus Iff

(His patch is currently in use at gamegrene.com, running 4.5.1).

------------------------------------------------------------------------

January 18, 2005 - 19:23 : Jeremy at kerneltrap.org

Seems to work like a charm -- thanks.  :)

------------------------------------------------------------------------

January 18, 2005 - 19:35 : moshe weitzman

please submit a patch for HEAD as well (if needed). link_node() no
longer exists so this patch is no help for HEAD

-- 
View: http://drupal.org/node/14936
Edit: http://drupal.org/project/comments/add/14936