[drupal-devel] [bug] Various bugs in filter tip display

Dries drupal-devel at drupal.org
Sun Jan 23 22:31:50 UTC 2005

 Project:      Drupal
 Version:      cvs
 Component:    filter.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Goba
 Reported by:  Goba
 Updated by:   Dries
 Status:       patch

Committed to HEAD.


Previous comments:

January 22, 2005 - 22:59 : Goba

Attachment: http://drupal.org/files/issues/Drupal-various-bug-in-filter-tips.patch (1.79 KB)

The theme_filter_tips() function has a $long attribute, which might have
been inserted between the two attributes around it, since some of the
function calls are not ready for passing that attribute. Therefor
sometimes $long gets the $extra parameter value, and sometimes $long is
missing (especially when long filter tips are displayed). Calling with
the proper parameters fixes this issue.

Also the $tip['id'] is directly used as a HTML id. But $tip['id']
contains things like 'bbcode/0' and 'glossary/0' and therefore is not
capable to being used as a HTML id. I prefixed the HTML id with
'filter-', as it used to be and converted the / to -, so the ids become
'filter-bbcode-0' and 'filter-glossary-0' respectively.

Patch attached. Might also be relevant for 4.5.x.


January 22, 2005 - 23:16 : Goba

By the way, the long filter tips page also lacks a breadcrumb. All other
pages have at least the 'Home' item in their breadcrumb, except the
homepage of course. I don't know where to solve this. Call
drupal_set_breadcrumb() or depend on the menu system? How?

View: http://drupal.org/node/16016
Edit: http://drupal.org/project/comments/add/16016

More information about the drupal-devel mailing list