[drupal-devel] [feature] i18n - Move drupal_goto to bootstrap.inc and some related features

chx drupal-devel at drupal.org
Sat Jan 29 17:53:24 UTC 2005

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     feature requests
 Priority:     normal
 Assigned to:  Jose A Reyero
 Reported by:  Jose A Reyero
 Updated by:   chx
 Status:       patch

moshe, I tried and failed. This early you can not call module_invoke.


Previous comments:

January 24, 2005 - 01:42 : Jose A Reyero

Attachment: http://drupal.org/files/issues/i18n_drupal_goto_01.patch (8.41 KB)

This is firs of a serie of patches adding support for some i18n related features.

This patch:
- moves drupal_goto to bootstrap.inc, making it possible to use it from the module_init, even for cached pages
- moves url() to bootstrap.inc, as it is needed by drupal_goto, and includes a check for not to resolve path aliases when called from bootstrap (it is not needed and would require including lot more stuff from common.inc)
- adds a simple hook to call 'i18n_url_rewrite' from the function 'url()' , which allows outgoing urls to be rewrited, so some additional info can be placed in the path.


January 24, 2005 - 07:09 : chx

I like this approach. First of all, it moves only a very little code from common to bootstrap. Second, it does not introduce new init mechanisms like all previous i18n revisions did. Third, the penalty for the code in the case i18n is off, is incredibly small -- one if per url() call. 


January 24, 2005 - 15:47 : moshe weitzman

Instead of writing a 3 line if() statement, you might use module_invoke('i18n_url_rewrite', $path). that goes for your other patches as well. improves readability slightly.

View: http://drupal.org/node/16069
Edit: http://drupal.org/project/comments/add/16069

More information about the drupal-devel mailing list