[drupal-devel] [feature] Taxonomy rewrite

[Mark Quinn]

On Mon, 31 Jan 2005 14:22:47 +0100, Jose A Reyero
<drupal-devel at drupal.org> wrote:
>  Project:      Drupal
>  Version:      cvs
>  Component:    taxonomy.module
>  Category:     feature requests
>  Priority:     normal
>  Assigned to:  chx
>  Reported by:  chx
>  Updated by:   Jose A Reyero
>  Status:       patch
> 
> Use cases:
> - Permissions for taxonomy terms/vocabs,  some tables and conditions
> must be joined for taxonomy queries
> - Multilanguage pages/taxonomy (i18n), additional conditions needed
> also for taxonomy
> 
> Jose A Reyero
> 
> 
> Previous comments:
> ------------------------------------------------------------------------
> 
> January 31, 2005 - 00:19 : chx
> 
> Attachment: http://drupal.org/files/issues/taxonomy_db_rewrite.patch (6.71 KB)
> 
> I'd like to present a use for db_rewrite_sql: taxonomy rewrites. If this
> goes through, it will be possible to create an access mechanism,
> languages and whatever for taxonomy.
> This is a very small change, I think, much smaller than the
> node_rewrite_sql megpatch was 'cos at the moment nothing changes. There
> are no DISTINCTs deleted. But this opens a door for future things.
> Also, this only affects taxonomy.module, 'cos no other module deals
> with term_data and vocabulary tables (well, forum.module does, but
> those queries does not need a rewrite).
> 
> 
> ------------------------------------------------------------------------
> 
> January 31, 2005 - 03:41 : moshe weitzman
> 
> please, let's identify some use cases before we run more queries through
> the regex and hooks implied by db_qeury_sql. There might be a good
> reason to do this, but you have to convince us.
> 
> 
> ------------------------------------------------------------------------
> 
> January 31, 2005 - 07:49 : chx
> 
> In my latest version of db_rewrite_sql, which Dries has not yet
> commited, regexs are not executed if not necessary. That version was
> created well before Moshe's post, and I'm pretty sure it will pass,
> 'cos it is not a feature but a bugfix patch actually.
> Until there are no implementations of hook_db_rewrite_sql which cares
> for primary_field=='vid' or 'tid' , the performance hit is minimal, no
> regexps.
> 
> 
> --
> View: http://drupal.org/node/16452
> Edit: http://drupal.org/project/comments/add/16452
> 
>