[drupal-devel] [feature] Custom registration fields should appear on admin/user/create

[chx]

Issue status update for http://drupal.org/node/23536

 Project:      Drupal
 Version:      cvs
 Component:    user.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  chx
 Reported by:  moshe weitzman
 Updated by:   chx
 Status:       patch
 Attachment:   http://drupal.org/files/issues/user_reg_0.patch (9.01 KB)

It was intentional that the check for required fields are skipped for
admins. I deleted that check.




chx



Previous comments:
------------------------------------------------------------------------

May 24, 2005 - 21:02 : moshe weitzman

When creating a new user as an admin, it is useful and even expected to
be able to complete all the profile fields which are available on the
usual registration form ... the approach might be to consolidate
registration so that both users and admins use a single form.




------------------------------------------------------------------------

June 26, 2005 - 00:27 : chx

Attachment: http://drupal.org/files/issues/user_reg.patch (8.69 KB)

At first I thought it'd be better if I'd keep the separate form, but
this version results in shorter code and it's not so ugly. However, if
you do not like it, I have the version which only adds the $extra to
user_admin_create.




------------------------------------------------------------------------

June 26, 2005 - 20:08 : killes at www.drop.org

I like this patch.




------------------------------------------------------------------------

June 28, 2005 - 03:53 : moshe weitzman

to me, this version is great as it unifies the registration code. i did
a code review and all looks good to me. i applied the patch and noticed
that


- i added a required checkbox field via profile.module. the check
appeared on the reg form without the 'required' marker and the
registration was accepted without checking the box. then i tried this
for a textfield and it properly showed the 'required' marker but it
didn't enforce the 'required' bit either. so then i tried to edit the
user and even then we seem not to be enforcing the 'required' bit. this
looks like a profile.module bug.


if you are up for it, you might want to investigate the above. but
truly, enforcing the required bit is not related to this patch. so +1
from me.