[drupal-devel] [task] Enhanced upload administration

[moshe weitzman]

Issue status update for 
http://drupal.org/node/25756
Post a follow up: 
http://drupal.org/project/comments/add/25756

 Project:      Drupal
 Version:      cvs
 Component:    upload.module
 Category:     tasks
 Priority:     normal
 Assigned to:  Junyor
 Reported by:  Junyor
 Updated by:   moshe weitzman
 Status:       patch

Looks useful to me. If I had more uploads on my dev site I would try it
out.


Some code comments:


- don't reuse upload_page() for both user and admin page. split off
admin stuff into a new menu callback which points to a new
upload_admin_page() function.
- in the query for admin page, don't directly use the UID when building
the $sql. instead, pass that as an argument at end of pager_query().
this protects against SQL injection attack
- do we really want to show file locations to regular users? i think
not.
- perhaps show node title in the file listing tables 


your proposed enhancements look swell to me.


related question: do attachments on unpublished nodes acount against
user quota? if so, user is powerless to delete them? this module could
fix that I think. when unpublished, i suggest showing node title
without hyperlink.




moshe weitzman



Previous comments:
------------------------------------------------------------------------

Sat, 25 Jun 2005 22:43:40 +0000 : Junyor

Attachment: http://drupal.org/files/issues/drupal-4-6.upload.junyor.patch (4.84 KB)

I've found the need to have some administration for file attachments. 
Here's a demo patch of some of the proposed added functionality.  This
functionality should easily allow users to get a list of the files
they've uploaded, so they can get rid of old files if they reach their
size limit.


Changes:
- Added an 'administer uploaded files' permission
- Added admin/uploads and 'my uploads', which list uploaded files


Planned changes:
- statistics for the 'my uploads' and admin/uploads pages with total
size of uploaded files and size limit
- functionality to delete/rename files (using checkboxes to select
multiple files)


Please comment on code quality, current functionality, and planned
functionality.  Thanks.


Patch applies to 4.6 and HEAD.




------------------------------------------------------------------------

Sat, 25 Jun 2005 23:57:07 +0000 : clydefrog

Sounds like a good idea from your description. I haven't tested, but a
quick glance at the patch shows an odd comment:


+/*
+ * Menu callback:
+ * Pages where users add and delete their subscriptions to nodes
+ */




------------------------------------------------------------------------

Sun, 26 Jun 2005 08:52:50 +0000 : Junyor

Oops.  That's what I get for copying code.  I'll fix that in the next
patch.