[drupal-devel] [bug] "Only variables can be passed by reference" to node_invoke()

[dcook]

Issue status update for 
http://drupal.org/node/26235
Post a follow up: 
http://drupal.org/project/comments/add/26235

 Project:      Drupal
 Version:      4.6.2
 Component:    node system
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  danielc
 Updated by:   dcook
 Status:       patch

This happens in a lot of places throughout Drupal.  So far, I've done
the same thing (save the result to a temp variable, then pass the temp
variable to the function) in the following places:


system.module line 25
system.module line 653
user.module line 1293




dcook



Previous comments:
------------------------------------------------------------------------

Sat, 02 Jul 2005 13:50:56 +0000 : danielc

Attachment: http://drupal.org/files/issues/node_invoke.diff (858 bytes)

A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev
and started getting errors when node_invoke() is called:


Fatal error: Only variables can be passed by reference in
c:\drupal\modules\node.module on line 702.


This patch fixes the problem by assigning the value to a variable
before passing it to node_invoke().


Thanks.




------------------------------------------------------------------------

Sun, 03 Jul 2005 15:30:30 +0000 : Dries

This can't be true ...




------------------------------------------------------------------------

Mon, 04 Jul 2005 23:26:34 +0000 : danielc

What "can't be true?"



<?php
// Under PHP php5.0-win32-200506251630
function foo(&$bar) {
}
foo('x');
?>




Fatal error: Only variables can be passed by reference in test.php on
line 5


--Dan


PS:  Congratulations on your wedding!




------------------------------------------------------------------------

Tue, 12 Jul 2005 15:56:12 +0000 : danielc

And I believe these references issues (here and in
http://drupal.org/node/26033 and http://drupal.org/node/26034)
will also come up with the just released PHP 4.4.0.




------------------------------------------------------------------------

Wed, 20 Jul 2005 23:18:13 +0000 : sjaensch

I can confirm this with PHP 5.1.0b2 and current CVS, will this patch be
merged?