[drupal-devel] [bug] Forums vocabulary title not localizable

[Bèr Kessels]

Issue status update for 
http://drupal.org/node/19534
Post a follow up: 
http://drupal.org/project/comments/add/19534

 Project:      Drupal
 Version:      cvs
 Component:    forum.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  calanya
 Updated by:   Bèr Kessels
 Status:       patch

-1: We should never ever t() any user submitted content. i18n will fix
this for you, because it allows translation of taxonomies.




Bèr Kessels



Previous comments:
------------------------------------------------------------------------

Sun, 27 Mar 2005 11:37:29 +0000 : calanya

The forums vocabulary title ('Forums') is not localizable.
Workaround is to directly edit the vocabulary table.




------------------------------------------------------------------------

Sun, 27 Mar 2005 12:12:46 +0000 : Goba

Attachment: http://drupal.org/files/issues/Drupal-forum-missing-t.patch (970 bytes)

Here is  a patch.




------------------------------------------------------------------------

Sun, 27 Mar 2005 15:41:14 +0000 : Steven

Where exactly is this title displayed? As far as I can tell, the
vocabulary is only saved once, so changing the localization won't
affect the title if you've already caused _forum_get_vid() to be
invoked one way or the other...




------------------------------------------------------------------------

Sun, 27 Mar 2005 16:17:51 +0000 : Goba

Steven, this title is surely displayed if you use some multifaceted
navigation tool (eg. taxonomy navigation modules).




------------------------------------------------------------------------

Sun, 27 Mar 2005 19:24:45 +0000 : Steven

Those were really two points, I guess it wasn't clear.


My point is that this patch does not appear to solve the problem if you
already have an untranslated forums title in the database. Changing the
localization at that point will not affect it, as the variable
"forum_nav_vocabulary" will be set.




------------------------------------------------------------------------

Sun, 27 Mar 2005 19:26:40 +0000 : Steven

I just realized, this patch will fail with multi-language sites. Only
one localization will be stored in the database, and keep being used
regardless of user choice.


This really needs a different fix for this and the earlier reason.




------------------------------------------------------------------------

Sun, 27 Mar 2005 19:29:14 +0000 : Goba

Steven, vocabulary names are single language all across Drupal. It
should not mean that Drupal should enforce an English name on the
forums vocab, should it? The idea is to populate the title field with
the site default locale on forum setup time.