[drupal-devel] [bug] locale.inc uses deprecated elements and attributes

breyten drupal-devel at drupal.org
Thu Jul 28 11:17:05 UTC 2005

Issue status update for 
Post a follow up: 

 Project:      Drupal
 Version:      cvs
 Component:    locale.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  wulff
 Updated by:   breyten
 Status:       patch

Better, but where did the CSS go? ;) Furthermore, I like semantic markup
better, ie. <em class="locale-untranslated"> instead of using spans.


Previous comments:

Thu, 28 Jul 2005 10:13:15 +0000 : wulff

Attachment: http://drupal.org/files/issues/locale.inc.html.patch (3.08 KB)


Uses the deprecated element <strike> - should be changed to <span
style=\"text-decoration: line-through;\">

Uses the deprecated attribute nowrap - should be changed to
style="white-space: nowrap;"

Also, method="POST" should be changed to method="post".

Applying these changes makes the 'manage strings' results page validate
as XHTML 1.0 strict.


Thu, 28 Jul 2005 10:16:56 +0000 : Junyor

I'd prefer to see the styling done in drupal.css, rather than inline. +1
for the fix, -1 for the implementation.


Thu, 28 Jul 2005 11:09:03 +0000 : wulff

Attachment: http://drupal.org/files/issues/locale.inc.patch (3.05 KB)

You are absolutely right. This patch fixes locale.inc.


Thu, 28 Jul 2005 11:10:46 +0000 : wulff

Attachment: http://drupal.org/files/issues/drupal.css_0.patch (424 bytes)

...and this one adds the styles to drupal.css.

More information about the drupal-devel mailing list