[drupal-devel] [bug] Whitespace/PRIMARY KEY standardizations for the SQL files.

[Steven]

Issue status update for 
http://drupal.org/node/17116
Post a follow up: 
http://drupal.org/project/comments/add/17116

 Project:      Drupal
 Version:      cvs
 Component:    database system
 Category:     bug reports
 Priority:     normal
 Assigned to:  drumm
 Reported by:  Anonymous
 Updated by:   Steven
 Status:       patch

Commited to HEAD.




Steven



Previous comments:
------------------------------------------------------------------------

Thu, 10 Feb 2005 04:31:32 +0000 : Anonymous

I just downloaded Drupal 4.5.2 and in the database.mysql file, there was
an error in one of the SQL statements.


In the CREATE TABLE filter_formats statement (lines 243-249), the error
is on line 248.


That line reads, PRIMARY KEY format (format)


If should read, PRIMARY KEY (format)




------------------------------------------------------------------------

Thu, 10 Feb 2005 15:24:06 +0000 : Jiminator

Attachment: http://drupal.org/files/issues/database.mysql (19.66 KB)

I posted this, but didn't have a log in at the time.  I'm attaching the
corrected file.


Jiminator.




------------------------------------------------------------------------

Sun, 20 Feb 2005 16:54:23 +0000 : Jeremy at kerneltrap.org

This bug was mis-advertantly assigned to the dba module.  It's regarding
the core mysql database file.  Reassigning.




------------------------------------------------------------------------

Wed, 16 Mar 2005 04:43:53 +0000 : Morbus Iff

Attachment: http://drupal.org/files/issues/01_dbtweak.patch (14.83 KB)

I could not replicate the error in HEAD with MySQL 4.0.15: the
database.mysql imported just fine, and the primary key was set properly
for the format column. With that said, this particular line does not
follow the format of any of the other PRIMARY KEYs in the MySQL file,
and thus, attached is a patch to standardize the format PRIMARY KEYs
are defined, as well as whitespacing. Same goes for the pgsql file.




------------------------------------------------------------------------

Thu, 28 Jul 2005 19:28:23 +0000 : drumm

Attachment: http://drupal.org/files/issues/dbtweak.patch (8.42 KB)

The whitespacing in the mysql file is fixed in HEAD. Attached is a patch
to remove a couple random double spaces and remove the double spacing in
the pgsql file.