[drupal-devel] [bug] New themable function theme_search_form to unify search form and put logic at the correct level

robertDouglass drupal-devel at drupal.org
Sat Jul 30 12:14:07 UTC 2005

Issue status update for 
Post a follow up: 

 Project:      Drupal
 Version:      cvs
 Component:    search.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  robertDouglass
 Reported by:  robertDouglass
 Updated by:   robertDouglass
 Status:       patch
 Attachment:   http://drupal.org/files/issues/make_search_themable.txt (3.99 KB)

The search form should be themable, but it shouldn't be left to the
theme('page') function to do this, as is the current implementation.
This patch adds a theme_search_form function to theme.inc (not search
module because that would cause a dependency) and removes the then
unneeded variables from the phptemplate.engine. Pushbutton and
Bluemarine are updated to take advantage of the new function.

In the current implementation, several variables are created needlessly
in phptemplate.engine (like the text for the button) and then pushed to
the template. This seems messy and this patch fixes that.

Remaining questions: should the function accept any parameters? I think
not, but other opinions are welcome.


More information about the drupal-devel mailing list