[drupal-devel] [bug] Various bugs in filter tip display

[Dries]

Issue status update for 
http://drupal.org/node/16016
Post a follow up: 
http://drupal.org/project/comments/add/16016

 Project:      Drupal
 Version:      cvs
 Component:    filter.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Goba
 Reported by:  Goba
 Updated by:   Dries
-Status:       patch (code needs review)
+Status:       patch (code needs work)

Not exactly elegant.  There must be a better way to do this, probably
using the menu system.




Dries



Previous comments:
------------------------------------------------------------------------

Sat, 22 Jan 2005 20:59:35 +0000 : Goba

Attachment: http://drupal.org/files/issues/Drupal-various-bug-in-filter-tips.patch (1.79 KB)

The theme_filter_tips() function has a $long attribute, which might have
been inserted between the two attributes around it, since some of the
function calls are not ready for passing that attribute. Therefor
sometimes $long gets the $extra parameter value, and sometimes $long is
missing (especially when long filter tips are displayed). Calling with
the proper parameters fixes this issue.


Also the $tip['id'] is directly used as a HTML id. But $tip['id']
contains things like 'bbcode/0' and 'glossary/0' and therefore is not
capable to being used as a HTML id. I prefixed the HTML id with
'filter-', as it used to be and converted the / to -, so the ids become
'filter-bbcode-0' and 'filter-glossary-0' respectively.


Patch attached. Might also be relevant for 4.5.x.




------------------------------------------------------------------------

Sat, 22 Jan 2005 21:16:38 +0000 : Goba

By the way, the long filter tips page also lacks a breadcrumb. All other
pages have at least the 'Home' item in their breadcrumb, except the
homepage of course. I don't know where to solve this. Call
drupal_set_breadcrumb() or depend on the menu system? How?




------------------------------------------------------------------------

Sun, 23 Jan 2005 22:31:48 +0000 : Dries

Committed to HEAD.




------------------------------------------------------------------------

Sun, 23 Jan 2005 22:33:18 +0000 : Dries

The breadcrumb is derived from the path registered to the menu system,
however, it can be overwritten by drupal_set_breadcrumb().




------------------------------------------------------------------------

Tue, 26 Jul 2005 13:13:57 +0000 : wulff

Attachment: http://drupal.org/files/issues/filter_16016.patch (1.3 KB)

The generated ID's are currently of the form 'filter-filter-n' (i.e.
filter-filter-0, filter-filter-1, etc.)


The attached patch is a simple attempt at added breadcrumbs to the long
filter tips page.