[drupal-devel] [bug] node_access_where_sql changed behaviour

chx drupal-devel at drupal.org
Sat Mar 5 10:14:19 UTC 2005


Issue status update for http://drupal.org/node/18418

 Project:      Drupal
 Version:      cvs
 Component:    node.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  chx
 Reported by:  chx
 Updated by:   chx
 Status:       patch
 Attachment:   http://drupal.org/files/issues/node_access_inter_name.patch (1.21 KB)

jonbob node_access_view_all patch changed the return value of
node_access_where_sql to empty which breaks nicely all queries which
are still using this function. This is a good incentive to upgrade to
db_rewrite_sql, yes, but I think it causes confusion, 'cos it is not
really trivial why the query suddenly not works. Let's make it trivial
-- rename it _node_access_where_sql, it is no longer a function to be
called from outside. node_access_join_sql similarly.


chx




More information about the drupal-devel mailing list