[drupal-devel] [bug] Do not display poll block when no polls are
active
Prometheus6
drupal-devel at drupal.org
Mon Mar 14 12:43:34 UTC 2005
Issue status update for http://drupal.org/node/14767
Project: Drupal
Version: cvs
Component: poll.module
Category: bug reports
-Priority: minor
+Priority: normal
Assigned to: Prometheus6
Reported by: Prometheus6
Updated by: Prometheus6
-Status: active
+Status: patch
Attachment: http://drupal.org/files/issues/POLL_HEAD_PATCH.txt (968 bytes)
Prometheus6
Previous comments:
------------------------------------------------------------------------
December 25, 2004 - 06:40 : Prometheus6
Attachment: http://drupal.org/files/issues/poll.patch (1.14 KB)
I use polls infrequently and want them on the sidebar when they are
active. But I don't want an inactive poll displayed for weeks or
months.
This patch changes the SQL that selects the latest poll to display. It
simply adds the requirement that the poll be active.
------------------------------------------------------------------------
December 25, 2004 - 06:41 : Prometheus6
Should be vs. CVS instead of 4.5
------------------------------------------------------------------------
December 26, 2004 - 15:02 : Dries
"JOIN poll p": should be "JOIN {poll} p" or things will break when
database prefixing is used.
"on p.nid=n.nid": should be "ON p.nid = n.nid". Use capital letters
for SQL keywords, and put spaces around "=".
Other than that, this looks like a bug fix.
------------------------------------------------------------------------
December 26, 2004 - 17:28 : Prometheus6
Attachment: http://drupal.org/files/issues/poll_0.patch (1.19 KB)
Bug fix, yes, but I figured if no one complained in so long it was
intentional. Or maybe most people that use polls use them frequently.
Two corrections to formatting, and braces around the table name added.
------------------------------------------------------------------------
March 13, 2005 - 15:16 : killes at www.drop.org
patch: **** malformed patch at line 12:
More information about the drupal-devel
mailing list