[drupal-devel] [bug] [pgsql] location field in locales_source is the wrong field type.,

[Steven]

Issue status update for http://drupal.org/node/11689

 Project:      Drupal
 Version:      cvs
 Component:    locale.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  killes at www.drop.org
 Reported by:  adrian
 Updated by:   Steven
 Status:       patch

The first patch was apparently applied to CVS already. But it seems that
in the pgsql code, the temporary column "old_location" is not dropped?
Still, we should decide on this... either we:
- Remove the substring checking completely and change "location" to
text in both pgsql and mysql.
or
- We go back to a 128-char location, change the db columns back, and
implement killes' improved checker.
By the way killes, I think the strlen($comm) < 128 in the while()
condition is unnecessary with your later check in place.


Steven



Previous comments:
------------------------------------------------------------------------

October 18, 2004 - 17:13 : adrian

Attachment: http://drupal.org/files/issues/pgsql_locales_fix.diff (2.09 KB)

here's the patch


------------------------------------------------------------------------

October 18, 2004 - 17:39 : killes at www.drop.org

The patch should not be neccessary becuase the location field is pruned
to contain 128 chars. But - at least for pgsql- it doesn#t hurt either.


------------------------------------------------------------------------

October 18, 2004 - 17:57 : adrian

here is an updated patch, which fixes the problem with too many unique
restraints on locales_target.


------------------------------------------------------------------------

October 18, 2004 - 17:59 : adrian

Attachment: http://drupal.org/files/issues/pgsql_taxo_bug_0.diff (1.96 KB)

err. here is the patch.


------------------------------------------------------------------------

October 18, 2004 - 19:17 : adrian

Attachment: http://drupal.org/files/issues/pgsql_locales_fix_0.diff (2.64 KB)

here is a corrected patch, it contained some cruft fromt he taxonomy
patch i made earlier


------------------------------------------------------------------------

October 18, 2004 - 20:53 : Goba

Killes, the 128 char check is improperly implemented (the length is
checked before a new substring of unknown length is added), so that
check needs to be fixed in the first place.


------------------------------------------------------------------------

October 18, 2004 - 20:55 : Goba

Killes, the 128 char check is improperly implemented (the length is
checked before a new substring of unknown length is added), so that
check needs to be fixed in the first place.


------------------------------------------------------------------------

March 13, 2005 - 21:31 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/locale-inc.patch (739 bytes)

How about this?