[drupal-devel] Re: [drupal:dries] /modules system.module

[Stefan Nagtegaal]

Op 22-mrt-05 om 8:49 heeft Tim Altman het volgende geschreven:

> On Mon, 21 Mar 2005 22:49:54 +0100, Stefan Nagtegaal  
> <Drupal-Devel at iStyledThis.nl> wrote:
>
>> Op 21-mrt-05 om 22:25 heeft drupal-devel at drupal.org het volgende  
>> geschreven:
>>
>>> User: dries	Branch: HEAD	Date: Mon, 21 Mar 2005 21:25:49 +0000
>>>
>>> Modified files:
>>>   /modules system.module
>>>
>>> Log message:
>>>   - Patch #18093 by Junyor: clean up handling of image toolkit code  
>>> in absence of
>>>     any toolkits.
>>>
>>> Links:
>>>    
>>> http://cvs.drupal.org/diff.php?path=drupal/modules/ 
>>> system.module&old=1.200&new=1.201
>> This is not uniform/consistent to the other code we currently have.
>>
>> Currently drupal just disables the options or doesn't display them at  
>> all. Which is - after a lot of patches - finally consistent..
>> Now, we are introducing something new again..
>>
>> Can't we make this either consistent with the rest of drupal?
>> Just don't display anything at all and put an message in the watchdog  
>> (WATCHDOG_NOTICE).. See also my patch for the image.inc here:  
>> http://drupal.org/node/18700.
>
> 	I did the patch this way based on some comments in  
> http://drupal.org/node/12384, namely that UI should be disabled, not  
> hidden.  Perhaps there's a better message we could use, but I don't  
> think hiding it altogether is the answer.
>
> -- 
> Tim Altman
When there is no image toolkit available, why would you want to see the  
option to select all this?? We do not do that anywhere in drupal, only  
with the "Clean url"-option..

Steven suggested a while back to use:
  watchdog($message, WATCHDOG_NOTICE) for things to notice.. See his  
comments on this thread, which is related.
http://drupal.org/node/18700


Stefan