[drupal-devel] [feature] More changes to forum help text

[Morbus Iff]

Issue status update for http://drupal.org/node/19434

 Project:      Drupal
 Version:      cvs
 Component:    forum.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  nysus
 Reported by:  nysus
 Updated by:   Morbus Iff
 Status:       patch

-1 on parts of this:

I dislike immensely your "Weight" modifications. Not only do you make
them self-referential ("This setting" - utterly useless text) but you
also hardcode their implementation ("+10 is the heaviest"). Likewise,
you've made them, IMO, TOO long and TOO wordy. And "Weight" is used for
various things throughout Drupal, so if you're gonna "fix" one, you
should really "fix" them all. Still, I don't like the way you've fixed
it.
Your function change is fine with me, but you've got no spaces between
your "if"/"else if" and the parenthesied text. You need the spaces to
match up with Drupal style.

Other than that, the other changes are fine with me.


Morbus Iff



Previous comments:
------------------------------------------------------------------------

March 25, 2005 - 08:16 : nysus

Attachment: http://drupal.org/files/issues/forum_help.patch (5.98 KB)

Here's some more changes to help text in the forum.module by order of
significance:


"Parent" selection help text: Added help description for this form item
found on "admin/forum/add/container" and "admin/forum/add/forum".  The
help description is different depending on whether the type of
component being added is a forum or a container.  This change required
the modifcation to the argument list passed to an internal function to
forum.module.
Removed duplicate help language created by the change above.
Cut the fat from the help blurb on the "create content" page.
"Weight" selection help text on "admin/forum/add/container" and
"admin/forum/add/forum": Improved wording and made it more detailed.
Help language for "name" and "description" fields on
"admin/forum/add/container" and "admin/forum/add/forum" pages made more
consistent and concise.
Changed instances of "topic discussions" to "discussion topics"