[drupal-devel] [bug] illegible form elements for content administration (Safari)

[Junyor]

Issue status update for http://drupal.org/node/17343

 Project:      Drupal
 Version:      cvs
 Component:    node.module
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  njivy
 Updated by:   Junyor
-Status:       fixed
+Status:       patch
 Attachment:   http://drupal.org/files/issues/fieldset.patch (1.51 KB)

Here's an alternative patch.  Instead of adding a BR, if you set
'overflow: hidden' on the fieldset, it will expand to contain all
floats.  It works well in Opera, Firefox, Safari, IE6/Win, and
IE5.2/Mac.
Also included in this patch is a fix for the problem Moshe mentioned. 
I removed the '.node-form fieldset { display: inline }' rule.  The
change didn't appear to cause any visual/functional differences in the
above browsers, except Safari (now it works ;)).


Junyor



Previous comments:
------------------------------------------------------------------------

February 15, 2005 - 00:43 : njivy

Attachment: http://drupal.org/files/issues/content_administration-Safari.jpg (33.21 KB)

Using Safari 1.2.4 under OS 10.3, the form elements for content
administration are not legible.  (The path is "admin/node".)  I am not
enough of a CSS whiz to directly propose a solution.  But I am willing
to test patches.
I attached a screenshot.


------------------------------------------------------------------------

February 15, 2005 - 15:43 : njivy

Oops. Wrong version.


------------------------------------------------------------------------

February 25, 2005 - 02:31 : mathias

This has been fixed [1].
[1] http://drupal.org/cvs?commit=13633


------------------------------------------------------------------------

March 27, 2005 - 06:00 : adrian

Attachment: http://drupal.org/files/issues/safari_error.jpg (11.03 KB)

I just found the admin menu similarly messed up in the 4.6RC. 
I flushed my drupal.css just in case, but the bug definitely persist.


------------------------------------------------------------------------

March 27, 2005 - 09:10 : Junyor

The same thing is happening in Opera.  I tracked it down to having a
floated object inside a fieldset.  Firefox uses the fieldset as the
containing block for the float, but Opera and Safari move the floated
content outside of the fieldset.


------------------------------------------------------------------------

March 27, 2005 - 13:09 : Goba

So then a container div might be a working solution.


------------------------------------------------------------------------

March 27, 2005 - 13:58 : adrian

Attachment: http://drupal.org/files/issues/safari_float_render.diff (1.29 KB)

Here is a patch that adds a break , with a class of 'clear' , and adds a
.clear class to the drupal.css file.
This is how I would fix it, but it's probably not semantically correct.
But it does fix the problem..


------------------------------------------------------------------------

March 27, 2005 - 13:58 : adrian

err. and it's a patch.


------------------------------------------------------------------------

March 27, 2005 - 14:37 : adrian

Attachment: http://drupal.org/files/issues/safari_float_render_0.diff (1.29 KB)

I'm using the coffee defense as to why I missed the . infront of the
.clear class


------------------------------------------------------------------------

March 27, 2005 - 14:45 : adrinux

I can't see any other way to fix that, adding an ID and setting height
on the fieldset would be just as ugly imo - maybe re-engineering the
whole form would work but this isn't really the time to do that! Steven
will moan at you for using a br probably :)


------------------------------------------------------------------------

March 27, 2005 - 16:54 : Steven

The original commit referenced above did not fix the problem completely,
it did make the node admin at least usable in Safari. Before, the form
items would overlap eachother.
Adrian's fix seems to work, and the br is sort of excusable in this
case, as the browser's behaviour is quite broken with regard to
fieldsets. Usually I use <span> to avoid nasty br issues in IE, but
there don't seem to be any in this case. <br class="clear"> could be
considered a CSS version of <br clear="both"> which is transitional
XHTML.
Commited to head.


------------------------------------------------------------------------

March 27, 2005 - 19:26 : Junyor

Looks good in Opera and Safari now, thanks.
The behavior of floats inside fieldsets is undefined in CSS, so it's
not really that they're broken.  They're just different. :)


------------------------------------------------------------------------

March 27, 2005 - 22:29 : moshe weitzman

Perhaps this is a good spot to mention that the author and timestamp
fields are broken on the node edit form in Safari. They have been
busted for a long time. The browser won't even click into those fields,
so they can't be changed. Perhaps the fix there is similar to the fix
submitted in this issue.


------------------------------------------------------------------------

March 27, 2005 - 23:30 : Junyor

The same solution will probably work there.