[drupal-devel] [bug] theme_image doesn't accept html attributes

[jjeff]

Issue status update for http://drupal.org/node/21397

 Project:      Drupal
 Version:      cvs
 Component:    theme system
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  jjeff
 Updated by:   jjeff
 Status:       patch
 Attachment:   http://drupal.org/files/issues/theme_image-attr_fix_0.patch (1.51 KB)

Whoops... Found a mistake in my code...


Here's the correction.


-Jeff




jjeff



Previous comments:
------------------------------------------------------------------------

April 26, 2005 - 21:45 : jjeff

Here's the theme_image function from theme.inc



<?php
 function theme_image($path, $alt = '', $title = '', $attr = '',
$getsize = true) {
  if (!$getsize || (file_exists($path) && (list($width, $height,
$type, $attr) = @getimagesize($path)))) {
    return "<img src=\"$path\" $attr alt=\"$alt\" title=\"$title\"
/>";
  }
} 
?>




Any arguments sent to the function for $attr get clobbered by the
getimagesize() call. And $getsize defaults to true, so in a call to:



<?php
 theme_image('files/images/foo', 'alt_text', 'title_text',
'align="left"') 
?>




the 'align="left"' never makes it to the page. The two attribute values
really should be able to coexist, allowing for both getsize attributes
and additional 'argumented' attributes as well.


I recommend changing the $attr in the second line to $imgattr, then
adding $imgattr to the tag returned in the third.


-Jeff




------------------------------------------------------------------------

May 2, 2005 - 10:44 : jjeff

Attachment: http://drupal.org/files/issues/theme_image-attr_fix.patch (1.51 KB)

Okay, here's a patch to fix the theme_image attribute problem.


I've also added a handler so that attributes can either be a string (as
they were in the past - although it wasn't working) or an associative
array.


I've marked this issue as critical because the current version of
theme_image() does not accept attributes at all.


-Jeff