[drupal-devel] [bug] Book printer friendly version does not recall filter_nodeapi, so many filters are broken

[puregin]

Issue status update for http://drupal.org/node/19377

 Project:      Drupal
 Version:      4.5.2
 Component:    book.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  matteo
 Reported by:  matteo
 Updated by:   puregin
 Status:       patch

Matteo, I agree that the call should be made in both book_print and
book_print_recurse
(this is done in the current CVS version, no?)


I just don't see why you're calling it twice in book_print in your
patch.


Sorry if I'm being dense - I'm not yet "in deep" with the code :)


Regards, Djun




puregin



Previous comments:
------------------------------------------------------------------------

March 24, 2005 - 05:22 : matteo

Attachment: http://drupal.org/files/issues/book_nodeapi_1.patch (1.11 KB)

Filter_nodeapi is not recalled when printing a book.
Here is a patch that solves the problem.
You can easiliy reproduce the problem by installing inline.module,
where images are regularly printed when viewing the pages, while
[inline] tag is not rendered when printing a printer-friendly page.


Matteo




------------------------------------------------------------------------

April 15, 2005 - 06:37 : matteo

Any news on this matter ??




------------------------------------------------------------------------

May 4, 2005 - 22:28 : puregin

Why is node_invoke_nodeapi() called twice (before and after $node->body
is appended to $output)?




------------------------------------------------------------------------

May 5, 2005 - 00:11 : matteo

The missing call to nodeapi is the one I added. that call executes the
filters that do not use _filter hook, as inline.module does.