[drupal-devel] [task] Sensible status messages for forum admin

[Steven]

Issue status update for http://drupal.org/node/19621

 Project:      Drupal
 Version:      cvs
 Component:    forum.module
 Category:     tasks
 Priority:     normal
 Assigned to:  drumm
 Reported by:  drumm
 Updated by:   Steven
 Status:       patch

This patch needs to be updated with the check plain patch. The term name
is not correctly escaped, but also, it should use theme('placeholder')
for putting the term name into a message, instead of hardcoding <em>
tags.




Steven



Previous comments:
------------------------------------------------------------------------

March 29, 2005 - 02:55 : drumm

Attachment: http://drupal.org/files/issues/forum.module_3.diff (6.73 KB)

We are making forums and forum containers here, not terms. This patch
returns a status so the calling code can set the appropriate message
(or no message at all). This has the happy side effect of preventing
any potential problems with calling this from when cron is running and
other similar situations. The define()s are done in common.inc to
encourage similarly architected code; separate UI from DB manipulation.




------------------------------------------------------------------------

March 29, 2005 - 10:48 : TDobes

+1... this might be used during module installation for modules that
require their own vocab or perhaps in the installer as a way to set up
some default categories for "instant" site creation.  Not cluttering
the screen with lots of drupal_set_messages would be a good thing in
these instances too.




------------------------------------------------------------------------

March 31, 2005 - 19:31 : drumm

Attachment: http://drupal.org/files/issues/forum.module_4.diff (7.35 KB)

Keeping up with CVS.




------------------------------------------------------------------------

March 31, 2005 - 23:05 : Dries

I'm going to put this on hold until after the Drupal 4.6 release.




------------------------------------------------------------------------

April 15, 2005 - 17:33 : Steven

Definite +1 for HEAD.




------------------------------------------------------------------------

April 15, 2005 - 18:15 : stefan nagtegaal

Indeed that this is a very nice patch!
+1 from me either..