[drupal-devel] Please lint your patches (was: [bug] Missing ) in locale.inc)

[Gerhard Killesreiter]

On Sun, 8 May 2005, robertDouglass wrote:

>  Attachment:   http://drupal.org/files/issues/locale.inc.patch.txt (1.11 KB)
>
> missing ) - syntax error.

Things like that don't need to happen. Before making your patches you
should always make sure that your files ares still valid php files.
You can do so by running php -l on them:

killes at Kaktus:~/drupal-ro/includes > php -l locale.inc
PHP Parse error:  parse error, unexpected ';' in locale.inc on line 26

Parse error: parse error, unexpected ';' in locale.inc on line 26
Errors parsing locale.inc

Some editors might have keybindings for this, people using other editors
will need to use the command line.

We don't want Dries to spend time on this.

Cheers,
	Gerhard