[drupal-devel] [drupal:dries] /database database.mysql database.pgsql

[Stefan Nagtegaal]

Op 8-mei-2005, om 21:11 heeft drupal-devel at drupal.org het volgende  
geschreven:

> User: dries    Branch: HEAD    Date: Sun, 08 May 2005 19:11:31 +0000
>
> Modified files:
>   /database database.mysql database.pgsql
>
> Log message:
>   - Patch #22319 by Ber: updated default database schems not to use  
> Xtemplate any more.
>
> Links:
>   http://cvs.drupal.org/diff.php?path=drupal/database/ 
> database.mysql&old=1.184&new=1.185
>   http://cvs.drupal.org/diff.php?path=drupal/database/ 
> database.pgsql&old=1.121&new=1.122
>
> -- 
> [ Drupal cvs list | http://list.drupal.org/ ]


Shouldn't the code in the database files be consistent either? So,  
instead of:
<code>
-INSERT INTO system VALUES ('themes/bluemarine/ 
xtemplate.xtmpl','bluemarine','theme','themes/engines/xtemplate/ 
xtemplate.engine',1,0,0);
-INSERT INTO system VALUES ('themes/engines/xtemplate/ 
xtemplate.engine','xtemplate','theme_engine','',1,0,0);
+INSERT INTO `system` VALUES ('themes/engines/phptemplate/ 
phptemplate.engine', 'phptemplate', 'theme_engine', '', 1, 0, 0);
+INSERT INTO `system` VALUES ('themes/bluemarine/page.tpl.php',  
'bluemarine', 'theme', 'themes/engines/phptemplate/ 
phptemplate.engine', 1, 0, 0);
</code>

we should do:

<code>
-INSERT INTO system VALUES ('themes/bluemarine/ 
xtemplate.xtmpl','bluemarine','theme','themes/engines/xtemplate/ 
xtemplate.engine',1,0,0);
-INSERT INTO system VALUES ('themes/engines/xtemplate/ 
xtemplate.engine','xtemplate','theme_engine','',1,0,0);
+INSERT INTO system VALUES ('themes/engines/phptemplate/ 
phptemplate.engine', 'phptemplate', 'theme_engine', '', 1, 0, 0);
+INSERT INTO system VALUES ('themes/bluemarine/page.tpl.php',  
'bluemarine', 'theme', 'themes/engines/phptemplate/ 
phptemplate.engine', 1, 0, 0);
</code>

Thoughts??? (Notice the backquotes, used in the applied patch)

---
Stefan Nagtegaal
http://www.istyledthis.nl/