[drupal-devel] [feature] Add IP lookup capabilities to the watchdog module

Chris Johnson drupal-devel at drupal.org
Tue May 10 17:42:42 UTC 2005


Issue status update for http://drupal.org/node/22494

 Project:      Drupal
 Version:      cvs
 Component:    watchdog.module
 Category:     feature requests
 Priority:     minor
 Assigned to:  Anonymous
 Reported by:  baudolino
 Updated by:   Chris Johnson
 Status:       patch

Several reasons:


1.  Yes, Apache can be configured to do this.  However, it is resource
intensive.  Apache would have to do a DNS reverse lookup request for
every IP address.  This is generally considered to be a bad idea on any
Apache server that has any kind of load.  Thus, it will be turned off on
most hosting arrangements.


2.  Not everybody runs Apache.  :-)


3.  It's convenient, somewhat useful and very lightweight to provide
it.




Chris Johnson



Previous comments:
------------------------------------------------------------------------

May 9, 2005 - 21:27 : baudolino

Attachment: http://drupal.org/files/issues/watchdog.add_IP_lookup.diff (972 bytes)

This small patch adds IP lookup capabilities to the watchdog module
using the free external site http://whois.sc. Basically, the IP becomes
clickable, and a new window opens which displays a lot of data about the
address in question. Might be useful for site administrators who need to
look at suspicious activites, spiders, harvesters etc.


I got this idea from the phpBB bulletin board software, which offers
this feature for administrators.


One line patch attached.




------------------------------------------------------------------------

May 10, 2005 - 07:46 : kbahey

+1 for this patch.


Shouldn't target="blank" read target="_blank" (with under score)?




------------------------------------------------------------------------

May 10, 2005 - 08:25 : Junyor

-1 for using the target attribute.  That's browsers UI functionality.




------------------------------------------------------------------------

May 10, 2005 - 09:32 : Bèr Kessels

another -1 on target blank; As nielsen points out
(http://www.useit.com/alertbox/9605.html #9) opening new windows is 


"Opening up new browser windows is like a vacuum cleaner sales person
who starts a visit by emptying an ash tray on the customer's carpet.
Don't pollute my screen with any more windows, thanks (particularly
since current operating systems have miserable window management).

"


------------------------------------------------------------------------

May 10, 2005 - 10:59 : baudolino

Attachment: http://drupal.org/files/issues/watchdog.add_IP_lookup_1.diff (957 bytes)

Updated version, removed "target=_blank".




------------------------------------------------------------------------

May 10, 2005 - 11:03 : chx

removed target? Then now I can +1 this.




------------------------------------------------------------------------

May 10, 2005 - 11:10 : killes at www.drop.org

Why is this usefull? Can't you set up Apache to do the looking up?


Just two random questions.







More information about the drupal-devel mailing list