[drupal-devel] [bug] file_check_location problems

[walkah]

Issue status update for http://drupal.org/node/23028

 Project:      Drupal
 Version:      cvs
 Component:    file system
 Category:     bug reports
 Priority:     critical
 Assigned to:  chx
 Reported by:  chx
 Updated by:   walkah
 Status:       patch

+1 - we obviously need it and  I think the approach is sane- it also
seems to work in my testing.


one thing - with this approach, though, is that chx's modifications
mean that files that /don't/ exist are gonna end up looking like :
files//etc/passwd (for example) when they come out of
file_create_path(). I, personally, don't see much issue in that..




walkah



Previous comments:
------------------------------------------------------------------------

May 16, 2005 - 17:40 : chx

Attachment: http://drupal.org/files/issues/file_check_location.patch (2.34 KB)

Loosely based on walkah's idea I have changed a bit file_check_location.
Most of the problems related to file_check_upload is gone now but still
we have one: the system temporary directory. Please really look at the
patch and let's decide whether file_check_upload is really necessary
for $directory_temp or not.