[drupal-devel] [feature] Make FactoryJoe happy -- overrideable
drupal.css
factoryjoe
drupal-devel at drupal.org
Thu May 19 19:23:50 UTC 2005
Issue status update for http://drupal.org/node/23210
Project: Drupal
Version: cvs
Component: theme system
Category: feature requests
Priority: normal
Assigned to: chx
Reported by: chx
Updated by: factoryjoe
Status: patch
Hey if it makes me happy, how can I not +1?
So this is the logic of this patch, to quell the whole drupal.css
controversy once and for all... Since themes can override themable
functions, I proposed doing something similarly drupally for the
drupal.css issue. Basically if a theme provides its own drupal.css, it
should use that to override the default. If the theme doesn't, then the
usual 'misc/drupal.css' file is linked.
CHX implemented this solution in 10 seconds and seems to accomplish
both protecting the backwards compatibility of themes that reply on
drupal.css while giving wacky themers like myself the ability to
override drupal.css completely.
Nice. +1.
factoryjoe
Previous comments:
------------------------------------------------------------------------
May 19, 2005 - 19:12 : chx
Attachment: http://drupal.org/files/issues/theme_settings_0.patch (913 bytes)
End the endless debates and provide a theme overrideable hook for
include misc/drupal.css. The idea (partially) comes from FactoryJoe.
------------------------------------------------------------------------
May 19, 2005 - 19:19 : Thox
+1 for sure. Backwards compatible /and/ makes FactoryJoe happy.
More information about the drupal-devel
mailing list