[drupal-devel] [bug] non-standard form fields

Dries drupal-devel at drupal.org
Tue May 24 20:32:00 UTC 2005

Issue status update for http://drupal.org/node/23531

 Project:      Drupal
 Version:      cvs
 Component:    user.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  Alex Reisner
 Updated by:   Dries
 Status:       patch

IMO, the usability of the forms degrades with this patch.  It makes them
look weird-ish.


Previous comments:

May 24, 2005 - 19:40 : Alex Reisner

User.module manually creates several form fields (on lines 1091 and
1664) rather than calling the form_ functions in common.inc. The fields
on line 1664 are lacking a class attribute and all are missing id
attributes, making their appearances difficult to control. It strikes
me as better if the form_ functions were used, but I don't know enough
about user.module to know if this is possible. At least the class and
id info should be added manually.

Relevant code:

*Line 1091*
$group .= form_item(t('Password'), '<input type="password"
class="form-password" name="edit[pass1]" size="12" maxlength="24" />
<input type="password" class="form-password" name="edit[pass2]"
size="12" maxlength="24" />', t('Enter your new password twice if you
want to change your current password, or leave it blank if you are
happy with your current password.'), NULL, TRUE);

*Line 1664*
$rows[] = array('<input type="text" size="32" maxlength="64"
name="edit[name]" />', '<input type="submit" name="op" value="'. t('Add
role') .'" />');


May 24, 2005 - 20:12 : Robin Monks

Attachment: http://drupal.org/files/issues/hard.coded.form.fields.patch (2.19 KB)

This patch should take care of that.  I was unable to get someone to
review it, so it may have a rough spot.


More information about the drupal-devel mailing list