[drupal-devel] [feature] More powerful way of combining terms

[Cvbge]

Issue status update for http://drupal.org/node/23262

 Project:      Drupal
 Version:      4.6.0
 Component:    taxonomy.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  Cvbge
 Updated by:   Cvbge
 Status:       patch

Warnings, not "errors"




Cvbge



Previous comments:
------------------------------------------------------------------------

May 20, 2005 - 10:51 : Cvbge

I'd like to have possibilty to use more then one type of operation at
once.
For example, I'd like to say taxonomy/term/1,2+3,4 (nodes with terms 1
and 2 or with terms 3 and 4), or
taxonomy/term/1,2+1,4 (that'd be the same as 1,(2+4) - it means terms
with 1 and (2 or 4))




------------------------------------------------------------------------

May 24, 2005 - 12:18 : Cvbge

Attachment: http://drupal.org/files/issues/taxonomy-not_operator-dirty_patch.diff (4.56 KB)

Since it's not easy to add mixed operators i've started with something
simpler - adding !term (not term) support. This allows to use something
like taxonomy/term/1,!3


The patch is just a test, it'll be completly rewritten to support mixed
operators (if I implement it), but at least shows that adding ! operator
is quite simple and can be done without big changes.




------------------------------------------------------------------------

May 25, 2005 - 12:22 : Cvbge

Attachment: http://drupal.org/files/issues/taxonomy-combined_operators-dirty_patch.diff (8.8 KB)

Here's another dirty patch - this time everything is implemented, but I
need to clean it up and make a patch against 4.6.0/cvs - currently it's
against little modified 4.6.0 version (but, OTOH, taxonomy_select_nodes
gets allmost completly rewritten so it does not matter too much).


This patch allows combining AND (,), OR (+) and NOT (!) operators for
taxonomy selections, e.g.
taxonomy/term/1,2+3+4,!5,!6/3




------------------------------------------------------------------------

May 25, 2005 - 13:26 : Cvbge

Attachment: http://drupal.org/files/issues/taxonomy-combined_operators-4.6.diff (10.47 KB)

Attached patch works, is cleaned, and is against DRUPAL-4-6 :)
Comments are welcome.


BTW, implicit object creating (taxonomy.module line 936: $current->tid
= $tids[0];, $current was NULL before that) is generating errors in
PHP5, as chx says. Probably needs to be fixed.