[drupal-devel] [feature] Improve grouping in default profile page

[moshe weitzman]

Issue status update for http://drupal.org/node/23633

 Project:      Drupal
 Version:      cvs
 Component:    profile.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  moshe weitzman
 Updated by:   moshe weitzman
 Status:       patch
 Attachment:   http://drupal.org/files/issues/profile_box.patch (605 bytes)

This time using theme('box') since form_group() is not valid outside of
a form (thanks breyten).




moshe weitzman



Previous comments:
------------------------------------------------------------------------

May 25, 2005 - 23:09 : moshe weitzman

Attachment: http://drupal.org/files/issues/profile.group.patch (634 bytes)

One reason our profile page look lame today is that there is no visual
or semantic grouping around a profile 'category'. This one line patch
fixes this.




------------------------------------------------------------------------

May 26, 2005 - 02:26 : breyten

elements are only allowed in forms though. But I agree that the grouping
should be improved.




------------------------------------------------------------------------

May 26, 2005 - 04:36 : breyten

I really meant fieldset elements. Sorry!




------------------------------------------------------------------------

May 26, 2005 - 11:50 : Bèr Kessels

IMO we should wait a little more with this, iuntill we have theme
wrapper. I have code already to creatre a patch for the profiles which
will use the theme_wrapper. It will also allow a bit better themeing og
the profile pages.
You can already see the DOM and the possibilities of the theme here:
http://84.244.1.246. That uses theme_wrapper , amongst others




------------------------------------------------------------------------

May 26, 2005 - 12:18 : moshe weitzman

Come on Ber. You want to wait on a 1 line patch? Beware of introducing
dependencies that aren't strictly necessary. This one line can be
changed again later. No big deal.