[drupal-devel] [task] Theme XML_icon should allow inline xml icons

[Bèr Kessels]

Issue status update for http://drupal.org/node/17028

 Project:      Drupal
 Version:      cvs
 Component:    theme system
 Category:     tasks
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  Bèr Kessels
 Updated by:   Bèr Kessels
-Status:       active
+Status:       patch

status must be patch




Bèr Kessels



Previous comments:
------------------------------------------------------------------------

February 8, 2005 - 23:44 : Bèr Kessels

Attachment: http://drupal.org/files/issues/theme_xml_icon_allow_inline.patch (862 bytes)

theme('xml_icon') uses hardcoded DIVS, which is great. But what Drupal
really needs is some method (and implemetations!) to allow xml icons in
lists. i.e. each forum should list an icon. 


This patch allows none-inline icons If Param inline is set to true, a
span is returned as wrapper, otherwise the default div is returned.s




------------------------------------------------------------------------

February 19, 2005 - 19:19 : tangent

Why aren't all xml icons inline? There is no reason I can think of.
Can't we just change them to span to eliminate the need for another
argument?




------------------------------------------------------------------------

February 19, 2005 - 20:05 : Bèr Kessels

we could.
But I beleive a block element should be a div and an inline should be
span. Off course you can achieve this with CSS, but I would like to
follow the semantics.
And a lot of XML icons are block elements. In fact: all of them
areblock elements in drupal ATM. So changing that would be semantically
incorrect.




------------------------------------------------------------------------

February 19, 2005 - 22:00 : tangent

Yes, they are ALL currently block elements because theme_xml_icon()
marks them up that way. My argument is that there is no justification
for using a block level tag (DIV) for an image. If it should be
displayed as a block then it will be contained in a block by the
calling code. If it should not then it will not be. I still see no
reason that it should be marked up with DIV.




------------------------------------------------------------------------

May 18, 2005 - 22:23 : Bèr Kessels

Attachment: http://drupal.org/files/issues/theme_xml_icon_allow_inline_0.patch (507 bytes)

this one changes it into a span;, like tangent suggests.