[drupal-devel] [bug] replace binary strings in node.module with hex encodings

[Steven]

Issue status update for http://drupal.org/node/24025

 Project:      Drupal
 Version:      4.6.0
 Component:    base system
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  danielc
 Updated by:   Steven
 Status:       patch

PS: If your editor converts them to question marks, it means it doesn't
support UTF-8 properly and only handles your local ANSI codepage. You
will run into many more issues. I use Notepad2 on Windows and it works
like a charm.




Steven



Previous comments:
------------------------------------------------------------------------

May 31, 2005 - 22:53 : danielc

Attachment: http://drupal.org/files/issues/node.module.nobinary.diff (864 bytes)

drupal/modules/node.module contains three binary strings.  The use of
binary strings causes problems in text editors incapable of handling
such strings.


For example, I have modified this file for internal use, but when I
save the file, the binary strings get converted to question marks. 
While someone could argue that I should get a better text editor, this
issue exists for many users, not just me.  Better yet, the solution is
simple...


PHP allows representing binary characters via hex encoding.  That's
what this patch does.


Thanks.




------------------------------------------------------------------------

June 1, 2005 - 00:23 : kbahey

+1 for this.


They never show up correctly for me (Linux. vim).




------------------------------------------------------------------------

June 1, 2005 - 01:19 : Steven

All Drupal code is UTF-8 encoded. Locale.inc contains many more such
strings and there's some in search.module too. Keeping them as
plain-text is vital to keeping the code readable, using hex escapes
reduces editability.


-1 on this.