[drupal-devel] hard coded page sizes

[Bèr Kessels]

Hi,

These are issues that indeed need attention too, often.

I would suggest to make it all 50, and then use a variable_get('foo', 50) in 
those hardcoded places. A configuration setting in drupal could then allow 
setting this. I would say /admin/settings/adminpages is a nice place to 
bundle all our administration settings. 

Just my €0.02
Bèr

On Tuesday 11 October 2005 22:16, David Reed wrote:
> I have a use to expose some of the admin type pages (logs, users etc)
> in a view with limited space available.  I noticed that the page size
> is hard coded in all modules that use drupals paging mechanism.  A
> quick glance reveals the following hard-coded pages sizes:
>
> watchdog = 50 lines
> user = 50 lines
> statistics = 30 lines
> comment = 50 lines
> poll = 50 lines
>
> I think it would be really usefull to provide a mechanism to override
> these hard-coded values.  I would suggest something simple like
> apending a value to the url in the query string for page size.  This
> value could be interogated by each module that calls
> theme_pager_link() to see if it should use it's hard-coded default or
> use an override.
>
> I'm more than happy to provide some patches for this but I wanted to
> make sure I wasn't missing a far easier way to solve this issue.
>
> Does anyone else see value in this?  Is there a better way to do this
> other than patching the core modules?