[drupal-devel] [task] Usability: Upload module needs a 'default' maxfile size setting

[m3avrck]

Issue status update for 
http://drupal.org/node/30025
Post a follow up: 
http://drupal.org/project/comments/add/30025

 Project:      Drupal
 Version:      cvs
 Component:    upload.module
 Category:     tasks
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  m3avrck
 Updated by:   m3avrck
 Status:       patch (code needs review)

I think originally there was a setting similiar to this however I'm not
sure if it was setting a 'Default' value or a 'Global' value for all
uploads. I think that is what the originaly problem was for taking it
out. This patch, coupled with my other patch:
http://drupal.org/node/30038 (rerolled if/when Form API gets in) makes
the administration of the upload settings page *very* easy and super
clean and intuitive as well.




m3avrck



Previous comments:
------------------------------------------------------------------------

Tue, 30 Aug 2005 15:15:02 +0000 : m3avrck

Problem: I've enabled upload.module I then later assign a few roles to
be able to upload files. All of a sudden this new, hidden setting
appears in Settings > Upload .. max file size and total file size for
*each* role that has this capability. Hmm, good thing I decided to
check back there! But where did those defaults come from, hmm.


Fix: There should be a 'default' setting in Settings > Upload for max
file size and total file size for *all* roles. Then, when I create a
role and assign it upload permissions, it should inherit these
defaults, which shouldn't be hardcode into Drupal anyways (as they are
now). However, after I assign this permission, override settings should
appear, as they currently do.


Benefits: If I assign uploads to 20 different roles I can have default
setting for them all instead of having to worry about changing them
all. Also, this fixes the obviously usability problem and makes this
module make more sense which is always a +1 :)




------------------------------------------------------------------------

Tue, 30 Aug 2005 15:20:59 +0000 : m3avrck

Correction, there should also be a default setting for extensions as
well.




------------------------------------------------------------------------

Tue, 30 Aug 2005 18:49:10 +0000 : m3avrck

Attachment: http://drupal.org/files/issues/upload.module_3.patch (3.29 KB)

Ok I've created a patch which fixes this problem. Thorougly test here,
please test and let me know! This certainly does simplify the
out-of-box experience with the upload.module.




------------------------------------------------------------------------

Tue, 30 Aug 2005 19:11:20 +0000 : m3avrck

Attachment: http://drupal.org/files/issues/upload.module_4.patch (3.54 KB)

Fixed a small bug caught by mozillman in IRC.




------------------------------------------------------------------------

Tue, 30 Aug 2005 20:01:49 +0000 : Souvent22

Tried patch. Seems to work ok. +1




------------------------------------------------------------------------

Fri, 02 Sep 2005 15:30:06 +0000 : walkah

+1 - perhaps i'm getting old and foggy - but isn't this how
upload.module used to work??




------------------------------------------------------------------------

Fri, 02 Sep 2005 15:32:34 +0000 : Junyor

There used to be a setting for max file size for the whole site, but I
don't think these defaults were listed anywhere.