[drupal-devel] [bug] After creating a book, empty book divs shouldn't be created

crunchywelch drupal-devel at drupal.org
Sat Sep 3 21:30:28 UTC 2005

Issue status update for 
Post a follow up: 

 Project:      Drupal
 Version:      cvs
 Component:    book.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  FactoryJoe at civicspacelabs.org
 Updated by:   crunchywelch
 Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/book.module_8.patch (3.06 KB)

Seems I tried to sneak in my timezone system.module patch as well ;).
Here is a patch without the system.module diff.


Previous comments:

Thu, 18 Nov 2004 02:09:07 +0000 : FactoryJoe at civicspacelabs.org

Attachment: http://drupal.org/files/issues/book_divs.png (9.83 KB)

This code creates a styled section beneath a new book:

<div class="book"><div class="nav"> <div class="links"><div
class="prev">&nbsp;</div><div class="next">&nbsp;</div></div> <div
class="titles"></div></div></div>  </div>

If there is no data to be displayed, empty divs should not be output.


Thu, 16 Jun 2005 18:26:57 +0000 : Robin Monks

The <div class="book"><div class="nav"> <div class="links"><div
class="prev">&nbsp;</div><div class="next">&nbsp;</div></div> <div
class="titles"></div></div></div></div> still exists.  Bumping up to



Sat, 03 Sep 2005 21:28:48 +0000 : crunchywelch

Attachment: http://drupal.org/files/issues/book.module_7.patch (7.89 KB)

Here is a patch that fixes this, it rearranges the theme_book_navigation
function logic to only output the navigation book div if there is
content to display.

More information about the drupal-devel mailing list