[drupal-devel] [bug] Can't delete subjects with '&' in title

[m3avrck]

Issue status update for 
http://drupal.org/node/27140
Post a follow up: 
http://drupal.org/project/comments/add/27140

 Project:      Drupal
 Version:      cvs
 Component:    contact.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  m3avrck
 Updated by:   m3avrck
 Status:       patch (code needs review)

+1 patch works great! Latest HEAD version applied with update.php works
great, modifies database correctly for MySQL (and PostgreSQL looks
correct as well) and contacts can now be deleted if they have '&' in
the subject. Also, dumped entire database and created from modified
database.mysql and everything works great. I'd say this patch is ready
to be committed!




m3avrck



Previous comments:
------------------------------------------------------------------------

Wed, 20 Jul 2005 14:57:03 +0000 : m3avrck

Using the site-wide contact forms, any subjects with an '&' cannot be
deleted. Clicking delete for these subjects brings up the expected
action flow, however, confirming the delete does nothing. Subject still
exists.




------------------------------------------------------------------------

Mon, 25 Jul 2005 13:45:38 +0000 : m3avrck

It appears this issue might be linked with this one:
http://drupal.org/node/23685


A problem with mod_rewrite and not the actual contact module.




------------------------------------------------------------------------

Wed, 31 Aug 2005 16:51:56 +0000 : Souvent22

Attachment: http://drupal.org/files/issues/contact.module_6.patch (4.7 KB)

Redid how contacts work. It now references contacts by ID instead of
their category as the unique identifier. It also allows for contacts to
have weights, so that one may control where the contact will appear in
the listing.




------------------------------------------------------------------------

Wed, 31 Aug 2005 16:53:01 +0000 : Souvent22

Attachment: http://drupal.org/files/issues/updates.inc (27.23 KB)

This is the update.inc for the database cahnges that goes along with
this patch.




------------------------------------------------------------------------

Wed, 31 Aug 2005 18:31:37 +0000 : Souvent22

Attachment: http://drupal.org/files/issues/contact.module_7.patch (4.5 KB)

Updated patch.




------------------------------------------------------------------------

Wed, 31 Aug 2005 18:31:55 +0000 : Souvent22

Attachment: http://drupal.org/files/issues/updates.inc_4.patch (1.29 KB)

Updated database patch.




------------------------------------------------------------------------

Sat, 03 Sep 2005 16:17:21 +0000 : Cvbge

Hi, 


0. You should keep all changes in one file, i.e. pake one patch, not
patch for every file
1. You should include changes for database/database.{mysql,pgsql}
2. IIRC auto_increment was depreciated, you should use db_next_id()
(but I see auto_increment in cvs...)
3. You use "WHERE cid = '%s'", but cid is integer so this should
probably be %d (although this probably would not break anything..)




------------------------------------------------------------------------

Wed, 07 Sep 2005 17:31:21 +0000 : Souvent22

Attachment: http://drupal.org/files/issues/contact_full.patch (6.38 KB)

Ok, I've taken your suggestions in, and i think I have it this time. Let
me know if this is a correct format for a patch. This only fixes the bug
of not being able to delete special characters.




------------------------------------------------------------------------

Wed, 07 Sep 2005 17:37:30 +0000 : m3avrck

Check your database updates, the UNIQUE fields don't look right
syntactically.




------------------------------------------------------------------------

Wed, 07 Sep 2005 18:23:07 +0000 : Souvent22

Attachment: http://drupal.org/files/issues/contact_full_0.patch (6.25 KB)

Ok, i apologize for the last upload. Pleasle ignore. I send the wrong
file. :-[. Anyway, here's a tested, tried, and correct patch.