[drupal-devel] [feature] Put all throttle settings in the same place

[drumm]

Issue status update for 
http://drupal.org/node/27818
Post a follow up: 
http://drupal.org/project/comments/add/27818

 Project:      Drupal
 Version:      cvs
 Component:    throttle.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  drumm
 Reported by:  drumm
 Updated by:   drumm
-Status:       patch (code needs review)
+Status:       patch (code needs work)

Doesn't apply anymore




drumm



Previous comments:
------------------------------------------------------------------------

Sat, 30 Jul 2005 00:21:16 +0000 : drumm

Attachment: http://drupal.org/files/issues/screenshot_12.png (37.86 KB)

Screenshot 1/2. The modules admin page.




------------------------------------------------------------------------

Sat, 30 Jul 2005 00:24:10 +0000 : drumm

Attachment: http://drupal.org/files/issues/screenshot_13.png (15.81 KB)

Screenshot 2/2. The throttle modules page.




------------------------------------------------------------------------

Sat, 30 Jul 2005 00:29:32 +0000 : drumm

Attachment: http://drupal.org/files/issues/throttle-modules.patch (9.73 KB)

This patch needs http://drupal.org/node/27804.


The throttle configuration is currently spread out on the modules page
and the block configuration page. This patch moves the module
throttling to a local task next to the throttle settings page. I have
not worked on moving block throttling yet since I want to see what the
reaction to this first part is.


If this is comitted I plan to move the block throttle checkboxes and
continue improving the modules page. With less interface elements the
modules page can be made even simpler that is it now.




------------------------------------------------------------------------

Sat, 30 Jul 2005 19:48:47 +0000 : drumm

forgot to label it as a patch




------------------------------------------------------------------------

Mon, 01 Aug 2005 20:21:27 +0000 : factoryjoe

+1 for moving throttle/performance settings to it's own page/tab


-1 for showing disabled modules; only list those that can be disabled


Issues:



* "turning on" throttling seems counter intuitive... like, all the
modules should be checked as given priority... then you DESELECT in
order to take it off the priority list. I guess the current UI is
opposite of most conventions... where you start with everything enabled
and then take things /off/ the list.
* The list is not a scalable UI. If I have 60 modules (*cough cough*)
I'll see the first 10-15 and ignore the rest. If you could sort by
processing weight ("these modules suck up tonnes of memory! disable
these first!") or by functionality, the list would be much more
manageable.
* I still think "throttle" is a terrible name. Like "taxonomy" people
don't readily know what it means and avoid it like the plague. From a
marketing perspective, this is bad news for Drupal since it may appears
that Drupal is slow when it really just needs to have its *performance*
settings tweaked.



------------------------------------------------------------------------

Mon, 01 Aug 2005 20:52:00 +0000 : killes at www.drop.org

-1 for adding yet another config page. teh throttle setting is fine
where it is.




------------------------------------------------------------------------

Wed, 03 Aug 2005 23:05:03 +0000 : drumm

Here is an updated patch which has all of the modules checked and may be
unchecked to disable them while throttled. It removes all disabled
modules and required modules from the list.


The page name 'throttle' is generated directly from the module's name.
Changing the module name or changing the mechanism which sets that
title is out of the scope of this patch.


Ordering by processing time or functionality can be done given a decent
algorithm to do that. Figuring out such an algorithm would be out of the
scope of this patch too since it would need some sort of monitoring
functionality as well. I think alphabetical is fine.


Does anyone have more feedback on creation of this local task page or
keeping it in the modules page?




------------------------------------------------------------------------

Wed, 03 Aug 2005 23:05:30 +0000 : drumm

Attachment: http://drupal.org/files/issues/throttle-modules_0.patch (9.54 KB)