[drupal-devel] [bug] "Only variables can be passed by reference" to file_check_directory()

danielc drupal-devel at drupal.org
Fri Sep 9 02:53:23 UTC 2005

Issue status update for 
Post a follow up: 

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  danielc
 Updated by:   danielc
-Status:       fixed
+Status:       patch (ready to be committed)
 Attachment:   http://drupal.org/files/issues/references45.diff (3.76 KB)

Attached is a patch for DRUPAL-4-5.  I will attach a patch for
DRUPAL-4-6 in a moment.

These patches, along with the one submitted by m3avrck, are a
combination of three bug reports into one patch per branch.  I will
mark the following two items duplicates of this:



Previous comments:

Thu, 30 Jun 2005 00:44:20 +0000 : danielc

Attachment: http://drupal.org/files/issues/file_create_path.diff (2.4 KB)

A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev
and started getting errors when file_check_directory() is called:

Fatal error: Only variables can be passed by reference in
c:\drupal\modules\system.module on line 653

This patch fixes the problem by assigning the values to variables
before passing them to file_check_directory().


(BTW: I'm no longer on on drupal-devel due to time constraints.)


Tue, 16 Aug 2005 23:08:21 +0000 : drumm

Patch still applies and does not cause any problems with PHP 4. I am
unable to test on PHP 5.


Thu, 08 Sep 2005 17:45:14 +0000 : m3avrck

Attachment: http://drupal.org/files/issues/user.module_5.patch (911 bytes)

Confirmed, 5.0.5 final causes this fatal error: Fatal error: Only
variables can be passed by reference in \drupal\modules\user.module on
line 1366

Rerolled patch against latest HEAD. system.module no longer needs to be
updated, only user.module does.


Thu, 08 Sep 2005 17:56:23 +0000 : m3avrck

Attachment: http://drupal.org/files/issues/modules_1.patch (2.13 KB)

Correction, still applies in system.module, new patch attached.


Thu, 08 Sep 2005 18:13:57 +0000 : m3avrck

Attachment: http://drupal.org/files/issues/modules_2.patch (4.6 KB)

Second and final correction, turns out there were *multiple* call by
reference errors in system.module (some fixed in HEAD) others not. This
patch corrects them all and correctly works with PHP 5.0.5 on second
round of testing.


Thu, 08 Sep 2005 18:29:11 +0000 : Souvent22

PHP Version 5.1.0b3

+1. Fixed all my errors for PHP5 regarding the "pass by refereance"
error. I found 3 specific cases which generated the error, and now I
have 0. Seems ready to go. For all who try this patch, please, as I
did, place what version of PHP you're running, so we know it works for
all 5.x.


Thu, 08 Sep 2005 19:46:25 +0000 : Dries

Committed to HEAD.  Thanks.

More information about the drupal-devel mailing list