[drupal-devel] [bug] taxonomy_save_vocabulary() should check for 'tags' not set

[Cvbge]

Issue status update for 
http://drupal.org/node/30956
Post a follow up: 
http://drupal.org/project/comments/add/30956

 Project:      Drupal
 Version:      cvs
 Component:    taxonomy.module
 Category:     bug reports
-Priority:     normal
+Priority:     critical
 Assigned to:  Anonymous
 Reported by:  Cvbge
 Updated by:   Cvbge
 Status:       patch (code needs review)

So I believe this bug renders forum module completly unusable, thus
priority critical.




Cvbge



Previous comments:
------------------------------------------------------------------------

Sun, 11 Sep 2005 21:16:40 +0000 : Cvbge

Attachment: http://drupal.org/files/issues/taxonomy_save_vocabulary-tags.diff (1 KB)

I've found a problem when using postgresql: when going to admin/forum
*for the first time* the module adds a taxonomy term or category
"Forum", using taxonomy_save_vocabulary() function [it's done in
_forum_get_vid()].
But it does not set "tags" in the array and then in
taxonomy_save_vocabulary()  you get error in sql:
pg_query(): Query failed: ERROR: invalid input syntax for integer: ""
query: INSERT INTO vocabulary (name, description, help, multiple,
required, hierarchy, relations, tags, weight, module, vid) VALUES
('Forums', '', '', 0, 1, 1, 0, '', 0, 'forum', '1')


I've fixed this by changing taxonomy_save_vocabulary so it check if
"tags" is set and if not it sets it to default. This function already
does similar checks for "nodes" and "weight".