[drupal-devel] [feature] admin/access hover help - little patch, big help

[moshe weitzman]

Issue status update for 
http://drupal.org/node/28301
Post a follow up: 
http://drupal.org/project/comments/add/28301

 Project:      Drupal
 Version:      cvs
 Component:    user.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  jjeff
 Reported by:  jjeff
 Updated by:   moshe weitzman
-Status:       patch (code needs review)
+Status:       patch (ready to be committed)

lets push this one line beauty to 'ready for commit'




moshe weitzman



Previous comments:
------------------------------------------------------------------------

Fri, 05 Aug 2005 19:59:52 +0000 : jjeff

Attachment: http://drupal.org/files/issues/admin.access.hover.help.patch (799 bytes)

Here's a patch that adds a 'title' tag to all of the checkboxes in the
admin/access grid. When you roll over the checkboxes in most browsers a
tool-tip box will pop up with information about what each checkbox is.


Examples:
"anonymous user : edit own blog"
"authenticated user : post comments"
"admin : administer filters"


On a site with many roles and many modules, it becomes very easy to
scroll away from the table headers, so this is essential for figuring
out what you're clicking. It doesn't solve all of the admin/access page
usability problems, but it does make the page a lot more usable.


Little patch. Big help.


-Jeff




------------------------------------------------------------------------

Sun, 07 Aug 2005 15:34:35 +0000 : Dries

Coding style needs work (incorrect use of spaces).  Shouldn't these
strings be translatable?




------------------------------------------------------------------------

Sun, 07 Aug 2005 17:41:21 +0000 : jjeff

Attachment: http://drupal.org/files/issues/admin.access.hover.help.v2.patch (804 bytes)

This should be better.


By 'incorrect use of spaces', do you mean spacing around the array keys
and values? I've fixed that and the $perm (permission) value now gets
translated. Role names aren't translated elsewhere on the admin/access
page, so I've left $name (role name) untranslated.


-Jeff




------------------------------------------------------------------------

Fri, 09 Sep 2005 16:09:37 +0000 : jjeff

Anyone want to review my code?


Thanks,
Jeff




------------------------------------------------------------------------

Fri, 09 Sep 2005 16:25:49 +0000 : m3avrck

Attachment: http://drupal.org/files/issues/user.module_6.patch (803 bytes)

Rerolled patch against current HEAD. Looks good to me and seems to be
pretty useful :)




------------------------------------------------------------------------

Fri, 09 Sep 2005 17:35:58 +0000 : Bèr Kessels

Attachment: http://drupal.org/files/issues/user.module_6_0.patch (805 bytes)

changed spaces. And created http://drupal.org/node/30785.