[drupal-devel] [bug] forum table definition missing fields

[Uwe Hermann]

Issue status update for 
http://drupal.org/node/30344
Post a follow up: 
http://drupal.org/project/comments/add/30344

 Project:      Drupal
 Version:      cvs
 Component:    database system
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  crunchywelch
 Updated by:   Uwe Hermann
-Status:       patch (code needs review)
+Status:       patch (code needs work)

There _are_ vid columns in current HEAD, so are these patches still
needed? The "shadow" column is still there, though. Also, I agree with
#5 (only one patch).




Uwe Hermann



Previous comments:
------------------------------------------------------------------------

Sat, 03 Sep 2005 21:02:51 +0000 : crunchywelch

Attachment: http://drupal.org/files/issues/database.mysql_6.patch (1.07 KB)

The database.* files do not contain the vid field in the forum table,
causing forum module to break when submitting forum topics.


Also, database.pgsql contains an old field called 'shadow' in the forum
table.


These patches fix this problem.




------------------------------------------------------------------------

Sat, 03 Sep 2005 21:03:18 +0000 : crunchywelch

Attachment: http://drupal.org/files/issues/database.pgsql_6.patch (1.07 KB)

Here is the postgres patch




------------------------------------------------------------------------

Sat, 03 Sep 2005 21:07:24 +0000 : crunchywelch

Attachment: http://drupal.org/files/issues/database.mysql_7.patch (331 bytes)

Oops, look like I combined the patches. Here is just the mysql version




------------------------------------------------------------------------

Sat, 03 Sep 2005 21:07:44 +0000 : crunchywelch

Attachment: http://drupal.org/files/issues/database.pgsql_7.patch (357 bytes)

and postgres




------------------------------------------------------------------------

Sat, 03 Sep 2005 21:12:02 +0000 : crunchywelch

fixing the title, project module is not my friend today :/




------------------------------------------------------------------------

Tue, 06 Sep 2005 20:33:40 +0000 : Cvbge

Postgres version is fine (although the patch should be made from the top
directory)


Also I believe that "aggregate" patches containing changes to all files
are better then many patches, each for one file. Less patches to track.