[drupal-devel] [bug] Comment pager not working in cvs?

[leafish_dylan]

Issue status update for 
http://drupal.org/node/26031
Post a follow up: 
http://drupal.org/project/comments/add/26031

 Project:      Drupal
 Version:      cvs
 Component:    comment.module
 Category:     bug reports
 Priority:     critical
-Assigned to:  Anonymous
+Assigned to:  leafish_dylan
 Reported by:  leafish_dylan
 Updated by:   leafish_dylan
-Status:       active
+Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/comment.module_30.patch (1.02 KB)

Comment paging has been broken in CVS for at least 3 months, yet only
one other person has noticed this? 


Here's a patch to fix the bug...




leafish_dylan



Previous comments:
------------------------------------------------------------------------

Wed, 29 Jun 2005 23:43:10 +0000 : leafish_dylan

I've just upgraded a 4.6.1 site to CVS and there's no comment pager on
nodes with more than $comments_per_page. Is this a bug, or it it one of
my modules? I've tested the site with various other themes, including
the defaults.




------------------------------------------------------------------------

Mon, 04 Jul 2005 23:41:03 +0000 : leafish_dylan

Can anybody confirm this? I can't find the problem.




------------------------------------------------------------------------

Fri, 15 Jul 2005 12:35:14 +0000 : leafish_dylan

Hello?




------------------------------------------------------------------------

Tue, 23 Aug 2005 14:12:16 +0000 : Uwe Hermann

Confirmed in HEAD. The problem is here (comment.module,
comment_render()):


      if ($pager = theme('pager', NULL, $comments_per_page, 0,
array('comments_per_page' => $comments_per_page))) {
        $output .= $pager;
      }


The $pager variable is empty (for whatever reason), hence no pager is
generated. I didn't debug this any further...




------------------------------------------------------------------------

Fri, 09 Sep 2005 21:11:26 +0000 : leafish_paul

Confirmed here too - can any one take a look at this?