[drupal-devel] [bug] input formats, unknown column 'format' when format is removed

[syllance]

Issue status update for 
http://drupal.org/node/31467
Post a follow up: 
http://drupal.org/project/comments/add/31467

 Project:      Drupal
 Version:      cvs
 Component:    filter.module
 Category:     bug reports
-Priority:     critical
+Priority:     normal
 Assigned to:  Anonymous
 Reported by:  syllance
 Updated by:   syllance
-Status:       active
+Status:       patch (code needs review)

issue is still there after a fresh update to latest head. having double
checked, i dont see any other fix than the one in the proposed patch
(changing table from node to node_revisions).


moving this to 'normal' bug as input formats are not deleted everyday,
and moving to status patch needs code review to include the fix in the
patch queue.




syllance



Previous comments:
------------------------------------------------------------------------

Sat, 17 Sep 2005 13:39:18 +0000 : syllance

Attachment: http://drupal.org/files/issues/filter_remove.patch (871 bytes)

When removing an input format, the filter.module set all nodes that was
using the removed format to the default one. This cause an error with
current head version :


user error: Unknown column 'format' in 'where clause'
query: UPDATE node SET format = 1 WHERE format = 5 in
/drupal/head/sandbox/database.mysql.inc on line 99


After checking, the new node revision system moves the 'format' column
to the 'node_revisions' table, and filter.module still try to change it
in the 'node' table.


imho, the query should be UPDATE node_revisions SET format=1 ..., at
least from what i understood of the new node revision system :)


A patch is attached to make the table change from node to
node_revisions in filter.module.