[development] Re: InnoDB and accesslog/ watchdog

Johan Forngren johan at forngren.com
Thu Aug 17 17:43:15 UTC 2006



Chris Johnson skrev:
> johan at forngren.com wrote:
>>> </lurk>
>>> Why not keep a global array of variables changed during the current
>>> request, and persist them during cleanup, instead of locking the 
>>> table and
>>> persisting a single variable during each variable_set call?
>>>
>>> That would make doing multiple variable_sets in one request about as
>>> expensive as a single call to variable_set, as well as providing 
>>> atomicity
>>> for multiple variables tweaked in one request.
>>> <lurk>
>>>
>>>     
>>
>> Great idea, however, there is one drwaback, what if exit() is called
>> before the variables are written?
>>   
>
> Smart-ass answer:  don't do that.
>
> But truly, one who is writing modules for Drupal should follow the 
> Drupal API.  If that API says never call exit(), then developers 
> should not do that.
>
> Is it not already the case that calling exit() prevents hook_exit() 
> and hook_footer() from being called, for instance?

Perheps we shoud add this to the coding standards then?


More information about the development mailing list