[development] Re: [Drupal bug] Aggregator module using wrong unique ID for feed items?

Steve Dondley sdondley at gmail.com
Wed May 3 11:03:14 UTC 2006


I'm going to hold off on making patches for the database and update
files until I'm sure this patch will be approved.

On 5/3/06, Zen <development at drupal.org> wrote:
> Issue status update for
> http://drupal.org/node/61433
> Post a follow up:
> http://drupal.org/project/comments/add/61433
>
>  Project:      Drupal
>  Version:      4.7.0
>  Component:    aggregator.module
>  Category:     bug reports
>  Priority:     normal
>  Assigned to:  Anonymous
>  Reported by:  Steve Dondley
>  Updated by:   Zen
> -Status:       patch (code needs review)
> +Status:       patch (code needs work)
>
> No idea about the issue, but if this requires a DB change, the patch
> should incorporate the changes to database.mysql (4.0 and 4.1),
> database.pgsql and updates.inc.
>
>
> Thanks,
> -K
>
>
>
>
> Zen
>
>
>
> Previous comments:
> ------------------------------------------------------------------------
>
> Tue, 02 May 2006 15:12:28 +0000 : Steve Dondley
>
> For background, please see: http://drupal.org/node/61427
>
>
> I don't know much about RSS but I think the aggregator should be using
> the *guid* of the feed item as the unique identifier and not the *url*
> of the feed item.
>
>
>
>
> ------------------------------------------------------------------------
>
> Tue, 02 May 2006 15:59:01 +0000 : Steve Dondley
>
> Attachment: http://drupal.org/files/issues/aggregator_dup.patch (3.5 KB)
>
> OK, here's a first stab at a fix.
>
>
>
>
> ------------------------------------------------------------------------
>
> Wed, 03 May 2006 06:35:19 +0000 : Steve Dondley
>
> One other thing:
>
>
> In addition to applying the patch, you have to create a new field in
> the aggregator_item table called "guid". It's a varchar with a length
> of 255.
>
>
>
>
>


--
Dondley Communications
http://www.dondleycommunications.com

Communicate or Die: American Labor Unions and the Internet
http://www.communicateordie.com


More information about the development mailing list