[development] theme/module name conflict
mistknight at gmail.com
Thu Apr 26 08:22:25 UTC 2007
Khaled's solution seems to be the most logical. By enforcing that only one
or the other be enabled we can avoid many problems. I can imagine a newbie
doing something like that to find himself very confused from the result.
Furthermore, without really diving into the core, there's almost no way to
figure out what's going on or to figure out that it has anything to do with
a module/theme name conflict. We'd be getting loads of issues that simply
can't be duplicated. If no one has any better ideas then I'll try to
implement a patch for this. Thanks.
On 4/26/07, Larry Garfield <larry at garfieldtech.com> wrote:
> When I setup our automated install scripts at work for creating new Drupal
> projects, I specifically set it up to have a site-specific module named
> <sitename> and a theme named <sitename>theme. Since the majority of the
> in <sitename>theme/template.php has a phptemplate_ prefix anyway, it's not
> really that weird to type.
> Option 1 is the current standard, since PHP doesn't offer true namespacing
> I don't think it's expected to for the foreseeable future. If writing
> own code, keeping in mind potential permutations of the things you name is
> probably a good idea for that reason.
> On Wednesday 25 April 2007 5:41 pm, Ashraf Amayreh wrote:
> > Hello all,
> > I ran into a very awkward bug today. I created a module and a theme for
> > client, and naturally, this module contained customizations and the
> > was a custom made theme. I named the module and the theme with the
> > name. Let's say the client was named abc so I created an abc module and
> > abc theme. When I implemented the abc_block hook I was surprised to find
> > that all blocks disappeared on all pages. Further investigation into the
> > core and I found that the culprit was the call to theme('block') which
> > mistakingly called abc_block thinking it was a theme override function
> > (rather than the hook it was).
> > I was wondering if this issue has been addressed before. I can think of
> > three possible solutions:
> > 1. Make it a standard that no theme and module should be named the same
> > (weak solution)
> > 2. Change all theme('block') calls to something else so no chance of
> > conflict could occur
> > 3. Change the hook name so that it won't conflict with the theme call
> > 4. Any suggestions???
> > Either 2 or 3 seem good enough to solve the problem. But I thought I'd
> > gouge some opinions before wasting time on a less-than-optimal patch.
> > Thanks :-)
> Larry Garfield AIM: LOLG42
> larry at garfieldtech.com ICQ: 6817012
> "If nature has made any one thing less susceptible than all others of
> exclusive property, it is the action of the thinking power called an idea,
> which an individual may exclusively possess as long as he keeps it to
> himself; but the moment it is divulged, it forces itself into the
> of every one, and the receiver cannot dispossess himself of it." --
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the development