[development] comment module: minor issue unreachable code

Gerhard Killesreiter gerhard at killesreiter.de
Tue Aug 21 20:00:35 UTC 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hans Wolters schrieb:
> Hi Andrew,
> 
> On 21-aug-2007, at 21:44, andrew morton wrote:
> 
>> On 8/21/07, Hans Wolters <hans at lonki.xs4all.nl> wrote:
>>> Hi there,
>>>
>>> In the comment module there is some code that will never be reached:
>>
>> Hi Hans, the proper place to mention this would be in Drupal's issue
>> queue. You can submit a bug report here:
>> http://drupal.org/node/add/project_issue/drupal/bug
> 
> Thanks, but currently this page seem to have some problems itself:
> 
> No content types available.
> 
> Or is this only for user nobody?

Yes.

Also, putting a break even if it can't be reached is IMO good coding style.

Cheers,
	Gerhard
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGy0Rjfg6TFvELooQRAoP7AJ9qd6ZLpupVuYmzmE+14EkMjcToSgCgtXs6
lu1yLkPbrDNieCYKynoiSAg=
=M/MK
-----END PGP SIGNATURE-----


More information about the development mailing list